-
Notifications
You must be signed in to change notification settings - Fork 351
Accessible links #11369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessible links #11369
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
| raise HTTPError(http_status.HTTP_403_FORBIDDEN, data={ | ||
| 'message_long': 'Your Gitlab token is deleted or invalid you may disconnect your Gitlab account and ' | ||
| 'reconnect with a valid token <a href="/settings/addons/">here</a>.' | ||
| 'message_long': 'Your GitLab token is deleted or invalid you may <a href="/settings/addons/">disconnect ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branding fix: https://about.gitlab.com/company/
| To approve this requst: <a href="${approval_link}">Click here</a>.<br> | ||
| To cancel this request: <a href="${disapproval_link}">Click here</a> | ||
| You can <a href="${approval_link}">approve this request</a>.<br> | ||
| Or you can <a href="${disapproval_link}">cancel this request</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Includes typo fix
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…ch field Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
faafb82 to
7b055ea
Compare
| <li>Upload supplemental, materials, data, and code to the OSF project associated with your ${document_type}. | ||
| <a href="https://help.osf.io/article/177-upload-a-preprint" target="_blank">Learn how</a></li> | ||
| <li>Preregister your next study. <a href="https://help.osf.io/345-create-registrations">Read more</a></li> | ||
| <li>Preregister your next study. See <a href="https://help.osf.io/345-create-registrations">Create a Registration</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
futa-ikeda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for going through and updating these! I've left a couple suggestions for potential readability improvements, and if you could remove the unneeded aria-label in gitlab/models.py, that would be much appreciated!
website/templates/emails/node_request_institutional_access_request.html.mako
Outdated
Show resolved
Hide resolved
fd5fae4 to
1f7e812
Compare
futa-ikeda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for missing this the first time around. Just a couple of minor updates I noticed, but otherwise, should be all good!
website/templates/emails/node_request_institutional_access_request.html.mako
Outdated
Show resolved
Hide resolved
1f7e812 to
eabab52
Compare
| <a href="${requester.absolute_url}">${requester.fullname}</a> has requested access to your ${node.project_or_component} "<a href="${node.absolute_url}">${node.title}</a>."<br> | ||
| <br> | ||
| To review the request, click <a href="${contributors_url}">here</a> to allow or deny access and configure permissions.<br> | ||
| <a href="${contributors_url}">Review the request</a> to allow or deny access and configure permissions.<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's one instance of dropping To
| % endif | ||
| <p> | ||
| To review the request, click <a href="${node.absolute_url}contributors/">here</a> to allow or deny access and configure permissions. | ||
| <a href="${node.absolute_url}contributors/">Review the request</a> to allow or deny access and configure permissions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the other instance of dropping To
| <li>Upload supplemental, materials, data, and code to the OSF project associated with your ${document_type}. | ||
| <a href="https://help.osf.io/article/177-upload-a-preprint" target="_blank">Learn how</a></li> | ||
| <li>Preregister your next study. <a href="https://help.osf.io/345-create-registrations">Read more</a></li> | ||
| Learn how to <a href="https://help.osf.io/article/177-upload-a-preprint" target="_blank">upload a preprint</a>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, this Learn how also deserves a fix.
| <a href="https://help.osf.io/article/177-upload-a-preprint" target="_blank">Learn how</a></li> | ||
| <li>Preregister your next study. <a href="https://help.osf.io/345-create-registrations">Read more</a></li> | ||
| Learn how to <a href="https://help.osf.io/article/177-upload-a-preprint" target="_blank">upload a preprint</a>.</li> | ||
| <li>Preregister your next study. Learn how to <a href="https://help.osf.io/345-create-registrations">create a registration</a>.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding .s because these now feel very much like sentences as opposed to random words.
futa-ikeda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for these updates! I'll leave an approval here, but will hold off on merging this, as I want to run this past a couple people on our end.
| Your submission ${reviewable.title}, submitted to ${reviewable.provider.name}, | ||
| has not been accepted. Your registration was returned as a draft so you can make the appropriate edits for resubmission. | ||
| <a href=${draft_registration.absolute_url}>Click here</a> to view your draft. | ||
| <a href=${draft_registration.absolute_url}>View your draft</a>. | ||
| % else: | ||
| Your submission <a href="${reviewable.absolute_url}">${reviewable.title}</a>, submitted to ${reviewable.provider.name}, has been accepted by the moderator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some areas where the $ sign has been removed for the template variables. Could you add those back in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? I think the $ is just being highlighted being the syntax highlighter doesn't think it's valid html (I don't think it understands .mako
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes, you're right! That makes more sense. Sorry for the confusion!
| <li>Submit your preprint to an APA-published journal. Learn about <a href="https://help.osf.io/article/376-preprints-home-page#Submitting-to-a-Moderated-Preprint-Service-nueKG">Submitting to a Moderated Preprint Service</a>.</li> | ||
| % endif | ||
| <li>Upload supplemental, materials, data, and code to the OSF project associated with your ${document_type}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more dropped $ here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines that aren't pink/green aren't changed by me, so that's definitely the syntax highlighter not understanding the syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sorry, definitely misread these syntax highlighting here too!
futa-ikeda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in getting back here. I've heard back from our product team, and we will be doing a bit of an overhaul of our email notifications, so they've requested that we don't introduce any changes to the email templates for now. If you could update this PR to remove the changes in website/templates/emails, that would be much appreciated! It seems everything else looks good!
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
…n form Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
eabab52 to
198567c
Compare
f6349e5
into
CenterForOpenScience:feature/pbs-25-21
|
Thank you so much for your work here! |
* link: documentation for this endpoint Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: download the contents of this repository Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: files in this repo Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: disconnect your GitLab account and reconnect with a valid token Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: more information on locations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: example of a full custom taxonomy and more information about each field Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: set a password Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: questions and comments Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: blank version of the Election Research Preacceptance Competition form Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: review the request Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: disable this feature Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: OSF Storage capacity Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Version history for this policy Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: view it as a contributor Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: withdraw its parent registration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: resend your confirmation email Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: set a password for your account Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: approve this ... Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: View your draft Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review and contribute to the updates in progress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review the updates in progress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review and either approve or reject the submitted updates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review the submited updates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: about preregistration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: list of storage provider keys Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * Remove bogus aria-label Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* [ENG-8769] Update waitress (#11290) * [ENG-8177] Institution dashboard not showing user affiliations for Projects, Registrations and Preprints tabs (#11276) * display only institution-specific user metrics reports * add missing exlude statement * [ENG-9015] Redesign legacy pages (#11353) * Update font-awesome * Update font-awesome import * Update CSS * Update footer * WIP nav and base mako * Update to styling for main content background * Update Orcid login page * Update leftnav links and styling; Add proper icons * Move maintenance banner to a more appropriate place * Remove old navbar * Appease jshint * Rework external_login_email_get&post without push status message --------- Co-authored-by: Longze Chen <cslzchen@gmail.com> * ENG-9127 add contributors from parent project to component * implement unit test for component project contributors from parent project updating * [ENG-9128] [Post-Release] P57 - [Contributors] Unregistered user’s “Set Password” link opens a blank page (#11367) * Add claim user api endpoint * Update ConfirmClaimUser endpoint to use 'guid' instead of 'pid' in payload and URL * [ENG-8655] Fix/eng 8655 (#11375) * Add a new page for pending preprint moderation * Add template for pending moderation * Remove new flask view * [ENG-9122]Update create_at field for versioned preprint (#11383) * [ENG-9002] allow gdpr delete for sole contribs (#11334) * [ENG-8479] Update user template for admin app (#11346) * [ENG-6223] chore: remove 'old' institution dashboard stuff (#11365) * fix test (#11394) * fix test * fix other serializers * linting * [ENG-9622] add legacy prefix to /claim/verify (#11386) * [ENG-8832] Most recent numbered version of a preprint fails to show for unversioned URL (#11315) * fix versioned guids resolving to the last published version instead of last version number * fix migration job * handle initial review_state in fix_versioned_guids job * adjusted tests to pass with new guid resolve strategy * handle the case for withdrawn/rejected preprints * fix missing.all() * fixed institution group lookup in admin (#11293) * [ENG-8516] Add contributor and update permissions functionality on admin (#11278) * added edit contributors button and basic table * added edit pop-up data display * moved remove functionality to a new edit contributors pop-up * added contributors removal and permissions update * added an ability to add a new contributor + html improvements * removed redundant code * fixed permissions * fixed test * added an ability to add multiple contributors + handle some edge cases * removed redundant conversion * fix test (#11394) * fix test * fix other serializers * linting * added edit contributors button and basic table * added edit pop-up data display * moved remove functionality to a new edit contributors pop-up * added contributors removal and permissions update * added an ability to add a new contributor + html improvements * removed redundant code * fixed permissions * fixed test * added an ability to add multiple contributors + handle some edge cases * removed redundant conversion * flake8 fix --------- Co-authored-by: Yuhuai Liu <yuhuai@cos.io> * [ENG-9122] Update fix (#11403) * [ENG-9060] Osf admin can recreate preprint version 1 with unregistered contributors (#11362) * osf admin can recreate preprint version 1 with unregistered contributors * fix test (#11394) * fix test * fix other serializers * linting * osf admin can recreate preprint version 1 with unregistered contributors --------- Co-authored-by: Yuhuai Liu <yuhuai@cos.io> * [ENG-8960] 2 Add registration date updated to activity logs (#11401) * Add ability for registration created date to be changed in admin * Add form * added log for registration date updated action in admin * Add REGISTRATION_DATE_UPDATED to activity logs --------- Co-authored-by: Ihor Sokhan <isokhan@exoft.net> * Copy global_reviews subscription changes to new_pending_submissions subscriptions [ENG-9666] (#11418) * [ENG-9025] Add the ability to remove moderators/admins from products (Registrations, Preprints, Collections, Institutions) in admin (#11373) * Refactor provider admin/moderator management * add preprint provider admin/moderator tests * [ENG-8828] Allow for the complete removal of a preprint (in initial state) from the database (#11330) * hard-delete draft preprint versions * check if user is staff before deleting preprint * remove breakpoint * fix tests * Accessible links (#11369) * link: documentation for this endpoint Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: download the contents of this repository Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: files in this repo Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: disconnect your GitLab account and reconnect with a valid token Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: more information on locations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: example of a full custom taxonomy and more information about each field Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: set a password Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: questions and comments Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: blank version of the Election Research Preacceptance Competition form Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: review the request Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: disable this feature Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: OSF Storage capacity Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Version history for this policy Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: view it as a contributor Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: withdraw its parent registration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: resend your confirmation email Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: set a password for your account Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: approve this ... Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: View your draft Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review and contribute to the updates in progress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review the updates in progress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review and either approve or reject the submitted updates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Review the submited updates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: about preregistration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: list of storage provider keys Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * Remove bogus aria-label Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * Spelling (#11379) * spelling: dashed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: data for Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: database Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: datacite Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: decode Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: deleted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: delimiters Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: descendents Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: description Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: desynchronized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: development Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: dictionaries Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: disconnect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: distinguishing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: draggable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: each Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: educational Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: effects tested Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: efficient Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: elsewhere Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: embargoed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: endpoint Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: engagement Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: enqueues Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: entire Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: entries Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: error Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: exactly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: exceeds Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: existence Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: existing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: expected Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: explicit Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: explicitly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: expression Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: extension Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: extract Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fall back Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fetch Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: filter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: finalize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: flag Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: flattened Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: flexibility Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: for Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: from Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: function Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: further Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: gitlab Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: given by the referrer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: gives users Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: greatgreatgrandchild Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: guarantee Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: guid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hierarchy Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hipaa Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: how you Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: icar Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: id Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: identifying Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: images Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: implicit Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: in Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: include Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: includes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: indeed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: information Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initially Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initiation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initiator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: input Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: install them Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instantiate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: institution Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: institutional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: institutions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instructions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: interface Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: interval Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: into Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: is contingent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: is Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: its Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: javascript Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: jira Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: jsonschema Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: justification Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: landing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: less Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: loading Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: log in Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: log Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: macos Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: maintenance Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: malformed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: management Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: manipulated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: manipulation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: marked Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: mechanism Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: message Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: metadata Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: method Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: methods Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: millisecond Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: milliseconds Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: moderator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: moving Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: multiple Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: normalize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: not Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: notifications Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: notify Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: oauth Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: objects Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: occurred Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: optional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: original Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: other analytic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: others Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: otherwise Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: our Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: overridden Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: paragraphs Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: parameter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: params Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: particular Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: permanently Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: persistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: pertaining Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: please Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: positioning Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preceded Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: predictions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preexisting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preparing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: prepopulate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preprint Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: private Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: probabilistic Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: programmatically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: progress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: propagates Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: provider Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: receive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: received Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: recommended Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: recommender Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: redirect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: referrer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: register Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registrations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registrationschema Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: remaining Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: remembered Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: remnants Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: replace Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: represent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: request Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: requires Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: resolve Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: resources Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: response Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: responses Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: responsible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: results Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retain Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retrieve Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retrieves Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: returned Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: reversion Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: rolled_back Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: rules Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sanitization Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sanitize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: save Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: scenario Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: schema Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: screen Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sendgrid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: separate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: serialized Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: set up Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: setting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: should Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: should_be Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: situations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: something Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: sorted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: specific Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: study Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: subclasses Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: submissions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: submitted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: successful Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: successfully Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: super bowl Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: supporting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: technically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: technique Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: template Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: test Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: than Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that a Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the p-values Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the sample Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: there are Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: there Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: threshold Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: through table Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: timed out Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: transactional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: transition Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: trench coat Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: triangles Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unflag Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unique Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: uniqueness Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unit tests Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: universally Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unmoderated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unnecessary Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unstructured Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unverified Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: updated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: user Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: username Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: users Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: verifications Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: version Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: versions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: view Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: waffle Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: waterbutler Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: website Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: weight Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: when Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: whether or not Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: whether Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: which Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: with Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: withdrawn Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: won't Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: your profile be visible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * [ENG-8516] osf admin can update contributor permission for any resource (#11407) * Remove duplicate import (#11427) * [ENG-8481] added systems tags management in admin for nodes and preprints (#11371) * added systems tags management in admin for nodes and preprints * added the ability to remove tags from nodes/registrations/preprints/users * [ENG-8630] Feature/azure blob storage (#11307) * Implement BaseFileNode for azure blob storage * fix review comments --------- Co-authored-by: An Qiuyu <qiuyu.an@hotmail.com> * Update license year * osf admin can remove contributors from any resource (#11436) * enable bulk request for registration contributors POST/PATCH * [ENG-9122] Fix/eng 9122 (#11435) * Update fix * add manage command to manual reindex preprints * Revert "[ENG-8832] Most recent numbered version of a preprint fails to show f…" (#11458) This reverts commit 77b8622. * [ENG-9740] Fix versioned guid resolution (#11438) * fix versioned guid resolution * fix linting * add unit tests * fix linting --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Vlad0n20 <137097005+Vlad0n20@users.noreply.github.com> Co-authored-by: antkryt <ant.krytskyi@gmail.com> Co-authored-by: futa-ikeda <51409893+futa-ikeda@users.noreply.github.com> Co-authored-by: Longze Chen <cslzchen@gmail.com> Co-authored-by: mkovalua <mkoval@exoft.net> Co-authored-by: Brian J. Geiger <bgeiger@cos.io> Co-authored-by: Ostap-Zherebetskyi <ozherebetskyi@exoft.net> Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com> Co-authored-by: Oleh Paduchak <158075011+opaduchak@users.noreply.github.com> Co-authored-by: ihorsokhanexoft <isokhan@exoft.net> Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: An Qiuyu <qiuyu.an@hotmail.com> Co-authored-by: futa-ikeda <futa.ikeda@gmail.com>
I'm sorry, the branch selection text above doesn't include accessible links explaining to a mortal how to determine if something should be a
hotfix. As such, I'm targetingdevelop, however I can easily rebase and change the destination branch.Purpose
Do not use
(click) herelinksFor more information, see:
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket